-
Notifications
You must be signed in to change notification settings - Fork 84
Add imageDigests to output to support multi-arch builds on native runners #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
CC @stuartleeks |
This is also needed for |
Ok I'm running into a little issue. If Would anything break if I moved loading the tar from the runPost to the main script? Will try it out, but warn me of potential pitfalls pls |
Ok, this is ready for review again. I have a sample workflow successfully working end-to-end (unfortunately in a private repo). The key change I made was coping the oci tar to docker at the end of the build, in addition to the beginning of the post-run step. I need extra review on whether thats ok, and whether I can safely remove the copy from the start of the post-run step. |
@chrmarti Can you help this? |
Interesting, I've actually found a bug after using this for a couple months:
Somewhere between the build completing and the digest output, the digest is getting "confused". The second digest in the logs above ( |
imageDigests
output to actionimageDigests
to do multi-arch builds on native runners in Github Actions